Fix for --version in osctrl-api and osctrl-cli#677
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the --version flag functionality for both osctrl-api and osctrl-cli commands by implementing proper version handling and adding build metadata support. The changes enable these tools to print version information and exit when the -v or --version flag is used.
- Adds build-time metadata variables for version, commit, and build date in both CLI and API main files
- Implements custom version printing with enhanced format showing version, commit, and date
- Updates build configuration to inject build metadata via ldflags
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/cli/main.go | Adds build metadata variables and custom version flag handling with -v alias |
| cmd/api/main.go | Adds build metadata variables, custom version handling, and restructures app action to prevent service startup on version requests |
| Makefile | Updates build targets to include build args and fixes test path reference |
| .goreleaser.yml | Updates ldflags to use new build metadata variable names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
osctrl-apiandosctrl-clito print out the version and exit when issuing the-v,--versionflag. Also adding metadata to build.