Merged
Conversation
javuto
added
osctrl-tls
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances service startup logging by displaying comprehensive build metadata (version, commit hash, and build date) when each osctrl service starts up.
- Removes redundant
serviceVersionconstants and usesbuildVersiondirectly - Adds logging of commit hash and build date alongside the existing version logging
- Updates handler initialization to use
buildVersioninstead ofserviceVersion
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/tls/main.go | Removes serviceVersion constant, adds build metadata logging for TLS service |
| cmd/api/main.go | Removes serviceVersion constant, adds build metadata logging for API service |
| cmd/admin/main.go | Removes serviceVersion constant, adds build metadata logging for Admin service |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cmd/api/main.go
Outdated
| log.Info().Msgf("%s v%s - HTTP listening %s", serviceName, buildVersion, serviceListener) | ||
| log.Info().Msgf("%s - commit=%s - build date=%s", serviceName, buildCommit, buildDate) | ||
| if err := http.ListenAndServe(serviceListener, muxAPI); err != nil { | ||
| log.Fatal().Msgf("ListenAndServeTLS: %v", err) |
There was a problem hiding this comment.
The error message mentions 'ListenAndServeTLS' but this code path is for HTTP (not HTTPS) listening. The message should be 'ListenAndServe' to match the actual function being called.
Suggested change
| log.Fatal().Msgf("ListenAndServeTLS: %v", err) | |
| log.Fatal().Msgf("ListenAndServe: %v", err) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display build metadata on service start