Skip to content

Prevent query to overflow table#726

Merged
javuto merged 1 commit intomainfrom
query-overflow-table
Oct 2, 2025
Merged

Prevent query to overflow table#726
javuto merged 1 commit intomainfrom
query-overflow-table

Conversation

@javuto
Copy link
Collaborator

@javuto javuto commented Oct 2, 2025

  • Use the correct field to display when a node was LastSeen
  • Prevent query to overflow the table
  • Some random formatting changes

@javuto javuto requested a review from Copilot October 2, 2025 21:39
@javuto javuto added the osctrl-admin osctrl-admin related changes label Oct 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes display issues in the admin interface by correcting the LastSeen field usage and preventing query text from overflowing table layouts.

  • Corrected LastSeen field to use n.LastSeen instead of n.UpdatedAt in JSON responses
  • Added CSS styling and HTML wrapping to prevent query text from overflowing tables
  • Applied minor formatting improvements to CSS with consistent quote usage and spacing

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/nodes/nodes.go Removed extra blank line for formatting consistency
cmd/admin/templates/queries.html Added div wrapper with styling to prevent query text overflow and condensed template variables
cmd/admin/templates/queries-logs.html Replaced inline styles with CSS class for query display
cmd/admin/static/css/custom.css Added new CSS classes for query styling and standardized quote usage/formatting
cmd/admin/handlers/json-nodes.go Fixed LastSeen field to use correct timestamp source

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@javuto javuto merged commit 8c84654 into main Oct 2, 2025
55 checks passed
@javuto javuto deleted the query-overflow-table branch October 2, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

osctrl-admin osctrl-admin related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants