Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes display issues in the admin interface by correcting the LastSeen field usage and preventing query text from overflowing table layouts.
- Corrected LastSeen field to use
n.LastSeeninstead ofn.UpdatedAtin JSON responses - Added CSS styling and HTML wrapping to prevent query text from overflowing tables
- Applied minor formatting improvements to CSS with consistent quote usage and spacing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/nodes/nodes.go | Removed extra blank line for formatting consistency |
| cmd/admin/templates/queries.html | Added div wrapper with styling to prevent query text overflow and condensed template variables |
| cmd/admin/templates/queries-logs.html | Replaced inline styles with CSS class for query display |
| cmd/admin/static/css/custom.css | Added new CSS classes for query styling and standardized quote usage/formatting |
| cmd/admin/handlers/json-nodes.go | Fixed LastSeen field to use correct timestamp source |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastSeen