Implement deferred Select2 initialization for tag modal#731
Merged
javuto merged 1 commit intojmpsec:mainfrom Oct 14, 2025
Merged
Implement deferred Select2 initialization for tag modal#731javuto merged 1 commit intojmpsec:mainfrom
javuto merged 1 commit intojmpsec:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements deferred initialization of the Select2 library for the tag modal to improve UI loading performance when dealing with large numbers of nodes. The main issue was that Select2 was being initialized immediately on page load, causing significant delays.
- Defers Select2 initialization until the tag modal is first opened
- Adds fallback mechanism to dynamically load Select2 from CDN if not available
- Prevents duplicate initialization with a ready flag
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
62e3a7d to
1b87121
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
javuto
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#635
This PR defers the loading of the
select2function, which significantly reduces UI loading time when handling a large number of nodes.Initially, I assumed the slowness was caused by loading a large dataset from the database all at once. However, after adding more detailed logs, I realized that this wasn’t the main bottleneck — most of the delay came from loading the
select2function.There are two root causes behind the issue:
This PR addresses the first issue by deferring the loading process. For now, it's okay to open the nodes list with 10k+ nodes.
For the second issue, we should stop generating meaningless tags. Currently, a tag is created for each node’s name and UUID, which are already unique identifiers. Tags should instead be used for grouping nodes — for example, by environment (
dev,prod), region (westeu,westus), or team/office. Once we remove these unnecessary tags, the UI performance should return to normal.