Fix for left side menus for query results and carves#733
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the left-side menu was not displaying properly on query logs and carve details pages. The fix reorganizes template conditional blocks and adds missing OsqueryValues to the template metadata structure.
- Restructures template conditionals to ensure proper menu rendering
- Adds OsqueryValues field to metadata for both query logs and carves handlers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/admin/templates/carves-details.html | Reorganizes template blocks and fixes conditional structure for proper menu display |
| cmd/admin/handlers/templates.go | Adds OsqueryValues field to metadata for QueryLogsHandler and CarvesDetailsHandler |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu in the left side was not shown properly for query logs and carve details.