Skip tag creation for UUIDs, localnames and hostname

cmd/admin/handlers/templates.go

@@ -1422,6 +1422,12 @@ func (h *HandlersAdmin) TagsGETHandler(w http.ResponseWriter, r *http.Request) {
 		log.Err(err).Msg("error getting tags")
 		return
 	}
+	// Get current tags count
+	tagsCount, err := h.Tags.CountTaggedNodes(tags)
+	if err != nil {
+		log.Err(err).Msg("error getting tags count")
+		return
+	}
 	// Get if the user is admin
 	user, err := h.Users.Get(ctx[sessions.CtxUser])
 	if err != nil {
@@ -1434,6 +1440,7 @@ func (h *HandlersAdmin) TagsGETHandler(w http.ResponseWriter, r *http.Request) {
 		Metadata:     h.TemplateMetadata(ctx, h.ServiceMetadata, user.Admin),
 		Environments: h.allowedEnvironments(ctx[sessions.CtxUser], envAll),
 		Tags:         tags,
+		CounterTags:  tagsCount,
 	}
 	if err := t.Execute(w, templateData); err != nil {
 		log.Err(err).Msg("template error")

cmd/admin/handlers/types-templates.go

@@ -225,6 +225,7 @@ type TagsTemplateData struct {
 	Environments []environments.TLSEnvironment
 	Platforms    []string
 	Tags         []tags.AdminTag
+	CounterTags  tags.TagCounter
 	Metadata     TemplateMetadata
 	LeftMetadata AsideLeftMetadata
 }

cmd/admin/templates/tags.html

@@ -49,10 +49,12 @@
                       <th>Color</th>
                       <th>Icon</th>
                       <th>Environment</th>
+                      <th>Tagged Nodes</th>
                       <th></th>
                     </tr>
                   </thead>
                   <tbody>
+                  {{ $counterTags := $.CounterTags }}
                   {{range  $i, $t := $.Tags}}
                     <tr>
                       <td>
@@ -70,6 +72,7 @@
                         <b>{{ environmentFinder $t.EnvironmentID $.Environments false }}</b>
                         <input type="hidden" value="{{ environmentFinder $t.EnvironmentID $.Environments true }}" id="tag_env_{{ $t.Name }}">
                       </td>
+                      <td>{{index $counterTags $t.ID}}</td>
                       <td>
                         <button type="button" class="btn btn-sm btn-ghost-danger" onclick="confirmDeleteTag('{{ $t.Name }}');">
                           <i class="far fa-trash-alt"></i>
@@ -138,13 +141,10 @@ <h4 id="modal_title_tag" class="modal-title"></h4>
                         <select class="form-control" name="tag_type" id="tag_type">
                           <option value=""></option>
                           <option value="0">Environment</option>
-                          <option value="1">UUID</option>
                           <option value="2">Platform</option>
-                          <option value="3">Localname</option>
                           <option value="4">Custom</option>
                           <option value="5">Unknown</option>
                           <option value="6">Tag</option>
-                          <option value="7">Hostname</option>
                         </select>
                       </div>
                     </div>

cmd/cli/node.go

@@ -163,12 +163,6 @@ func tagNode(c *cli.Context) error {
 	switch tagType {
 	case tags.TagTypeEnvStr:
 		tagTypeInt = tags.TagTypeEnv
-	case tags.TagTypeUUIDStr:
-		tagTypeInt = tags.TagTypeUUID
-	case tags.TagTypeLocalnameStr:
-		tagTypeInt = tags.TagTypeLocalname
-	case tags.TagTypeHostnameStr:
-		tagTypeInt = tags.TagTypeHostname
 	case tags.TagTypePlatformStr:
 		tagTypeInt = tags.TagTypePlatform
 	case tags.TagTypeTagStr:

pkg/tags/tags.go

@@ -44,18 +44,12 @@ const (
 	ActionUntag string = "untag"
 	// TagCustomEnv as custom tag for environment name
 	TagCustomEnv string = TagTypeEnvStr
-	// TagCustomUUID as custom tag for node UUID
-	TagCustomUUID string = TagTypeUUIDStr
 	// TagCustomPlatform as custom tag for node platform
 	TagCustomPlatform string = TagTypePlatformStr
-	// TagCustomLocalname as custom tag for node localname
-	TagCustomLocalname string = TagTypeLocalnameStr
 	// TagCustomUnknown as custom tag for unknown tags
 	TagCustomUnknown string = TagTypeUnknownStr
 	// TagCustomTag as custom tag for regular tags
 	TagCustomTag string = TagTypeTagStr
-	// TagCustomHostname as custom tag for hostname tags
-	TagCustomHostname string = TagTypeHostnameStr
 )
 
 // AdminTag to hold all tags
@@ -90,6 +84,9 @@ type TaggedNode struct {
 	UserID     uint
 }
 
+// TagCounter to hold tagged node counts
+type TagCounter map[uint]int
+
 // TagManager have all tags
 type TagManager struct {
 	DB *gorm.DB
@@ -148,13 +145,9 @@ func (m *TagManager) New(name, description, color, icon, user string, envID uint
 	case TagTypeEnv:
 		tagCustom = TagCustomEnv
 		cohort = true
-	case TagTypeUUID:
-		tagCustom = TagCustomUUID
 	case TagTypePlatform:
 		tagCustom = TagCustomPlatform
 		cohort = true
-	case TagTypeLocalname:
-		tagCustom = TagCustomLocalname
 	case TagTypeCustom:
 		tagCustom = custom
 	case TagTypeUnknown:
@@ -399,7 +392,7 @@ func (m *TagManager) ChangeEnvironment(tag *AdminTag, envID uint) error {
 
 // AutoTagNode to automatically tag a node based on multiple fields
 func (m *TagManager) AutoTagNode(env string, node nodes.OsqueryNode, user string) error {
-	l := []string{env, node.UUID, node.Platform, node.Localname}
+	l := []string{env, node.Platform}
 	return m.TagNodeMulti(l, node, user, true, "")
 }
 
@@ -538,8 +531,21 @@ func (m *TagManager) GetNodeTags(tagged []AdminTag) ([]AdminTagForNode, error) {
 // GetTaggedNodes to retrieve tagged nodes with a given tag name and environment
 func (m *TagManager) GetTaggedNodes(tag AdminTag) ([]TaggedNode, error) {
 	var tagged []TaggedNode
-	if err := m.DB.Where("id = ?", tag.ID).Find(&tagged).Error; err != nil {
+	if err := m.DB.Where("admin_tag_id = ?", tag.ID).Find(&tagged).Error; err != nil {
 		return tagged, err
 	}
 	return tagged, nil
 }
+
+// CountTaggedNodes to count tagged nodes for a given list of tags
+func (m *TagManager) CountTaggedNodes(tags []AdminTag) (TagCounter, error) {
+	tagCounter := make(TagCounter)
+	for _, t := range tags {
+		tagged, err := m.GetTaggedNodes(t)
+		if err != nil {
+			return tagCounter, err
+		}
+		tagCounter[t.ID] = len(tagged)
+	}
+	return tagCounter, nil
+}

pkg/tags/utils.go

@@ -10,14 +10,8 @@ import (
 const (
 	// TagTypeEnvStr is the tag type for shortened environment
 	TagTypeEnvStr = "env"
-	// TagTypeUUIDStr is the tag type for UUID
-	TagTypeUUIDStr = "uuid"
 	// TagTypePlatformStr is the tag type for platform
 	TagTypePlatformStr = "platform"
-	// TagTypeLocalnameStr is the tag type for localname
-	TagTypeLocalnameStr = "localname"
-	// TagTypeHostnameStr is the tag type for hostname
-	TagTypeHostnameStr = "hostname"
 	// TagTypeCustomStr is the tag type for custom
 	TagTypeCustomStr = "custom"
 	// TagTypeUnknownStr is the tag type for unknown
@@ -50,14 +44,8 @@ func TagTypeDecorator(tagType uint) string {
 	switch tagType {
 	case TagTypeEnv:
 		return TagTypeEnvStr
-	case TagTypeUUID:
-		return TagTypeUUIDStr
 	case TagTypePlatform:
 		return TagTypePlatformStr
-	case TagTypeLocalname:
-		return TagTypeLocalnameStr
-	case TagTypeHostname:
-		return TagTypeHostnameStr
 	case TagTypeCustom:
 		return TagTypeCustomStr
 	case TagTypeTag:
@@ -72,12 +60,8 @@ func TagTypeParser(tagType string) uint {
 	switch strings.ToUpper(tagType) {
 	case strings.ToUpper(TagTypeEnvStr):
 		return TagTypeEnv
-	case strings.ToUpper(TagTypeUUIDStr):
-		return TagTypeUUID
 	case strings.ToUpper(TagTypePlatformStr):
 		return TagTypePlatform
-	case strings.ToUpper(TagTypeLocalnameStr):
-		return TagTypeLocalname
 	case strings.ToUpper(TagTypeCustomStr):
 		return TagTypeCustom
 	case strings.ToUpper(TagTypeTagStr):
@@ -93,14 +77,8 @@ func SetCustomTag(tagType uint, custom string) string {
 	switch tagType {
 	case TagTypeEnv:
 		tagCustom = TagCustomEnv
-	case TagTypeUUID:
-		tagCustom = TagCustomUUID
 	case TagTypePlatform:
 		tagCustom = TagCustomPlatform
-	case TagTypeLocalname:
-		tagCustom = TagCustomLocalname
-	case TagTypeHostname:
-		tagCustom = TagCustomHostname
 	case TagTypeCustom:
 		tagCustom = custom
 	case TagTypeUnknown:
@@ -138,12 +116,8 @@ func ValidateCustom(anyCustom string) string {
 	switch strings.ToUpper(anyCustom) {
 	case strings.ToUpper(TagTypeEnvStr):
 		return TagTypeEnvStr
-	case strings.ToUpper(TagTypeUUIDStr):
-		return TagTypeUUIDStr
 	case strings.ToUpper(TagTypePlatformStr):
 		return TagTypePlatformStr
-	case strings.ToUpper(TagTypeLocalnameStr):
-		return TagTypeLocalnameStr
 	case strings.ToUpper(TagTypeCustomStr):
 		return TagTypeCustomStr
 	case strings.ToUpper(TagTypeTagStr):

pkg/tags/utils_test.go

@@ -20,27 +20,21 @@ func TestGetHex(t *testing.T) {
 
 func TestTagTypeDecorator(t *testing.T) {
 	assert.Equal(t, "env", TagTypeDecorator(0))
-	assert.Equal(t, "uuid", TagTypeDecorator(1))
 	assert.Equal(t, "platform", TagTypeDecorator(2))
-	assert.Equal(t, "localname", TagTypeDecorator(3))
 	assert.Equal(t, "custom", TagTypeDecorator(4))
 	assert.Equal(t, "unknown", TagTypeDecorator(5))
 }
 
 func TestTagTypeParser(t *testing.T) {
 	assert.Equal(t, uint(0), TagTypeParser("env"))
-	assert.Equal(t, uint(1), TagTypeParser("uuid"))
 	assert.Equal(t, uint(2), TagTypeParser("platform"))
-	assert.Equal(t, uint(3), TagTypeParser("localname"))
 	assert.Equal(t, uint(4), TagTypeParser("custom"))
 	assert.Equal(t, uint(5), TagTypeParser("unknown"))
 }
 
 func TestTagCustom(t *testing.T) {
 	assert.Equal(t, "env", SetCustomTag(0, "CUSTOM-VALUE"))
-	assert.Equal(t, "uuid", SetCustomTag(1, "CUSTOM-VALUE"))
 	assert.Equal(t, "platform", SetCustomTag(2, "CUSTOM-VALUE"))
-	assert.Equal(t, "localname", SetCustomTag(3, "CUSTOM-VALUE"))
 	assert.Equal(t, "CUSTOM-VALUE", SetCustomTag(4, "CUSTOM-VALUE"))
 	assert.Equal(t, "unknown", SetCustomTag(5, "CUSTOM-VALUE"))
 }