Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes configuration naming conventions across services to prepare for a unified YAML configuration file. The changes focus on correcting a typo in Kafka configuration and aligning field naming to use camelCase in YAML/JSON tags.
Key changes:
- Fixed "BoostrapServer" typo to "BootstrapServer" in Kafka configuration
- Standardized YAML tag naming from lowercase to camelCase for SAML and Kafka configurations
- Added SAML configuration to AdminConfiguration struct
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/config/types.go | Fixed Kafka configuration typo, standardized YAML tags to camelCase, and added SAML config to AdminConfiguration |
| pkg/logging/kafka.go | Updated reference to use corrected BootstrapServer field name |
| pkg/config/flags.go | Updated flag destination to use corrected BootstrapServer field name |
| cmd/tls/main.go | Renamed function and extracted YAML config type to constant, added unmarshal step |
| cmd/api/main.go | Renamed function, extracted YAML config type to constant, added unmarshal step, and corrected flag initialization call |
| cmd/admin/main.go | Renamed function, extracted YAML config type to constant, and added unmarshal step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing things to have a single YAML configuration file across all services. #644