Skip to content

Preparation to have SAML config file#748

Merged
javuto merged 1 commit intomainfrom
yaml-config-admin
Nov 25, 2025
Merged

Preparation to have SAML config file#748
javuto merged 1 commit intomainfrom
yaml-config-admin

Conversation

@javuto
Copy link
Copy Markdown
Collaborator

@javuto javuto commented Nov 25, 2025

Preparing things to have a single YAML configuration file across all services. #644

@javuto javuto requested a review from Copilot November 25, 2025 08:30
@javuto javuto added the ⚙️ configuration Configuration related issues label Nov 25, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes configuration naming conventions across services to prepare for a unified YAML configuration file. The changes focus on correcting a typo in Kafka configuration and aligning field naming to use camelCase in YAML/JSON tags.

Key changes:

  • Fixed "BoostrapServer" typo to "BootstrapServer" in Kafka configuration
  • Standardized YAML tag naming from lowercase to camelCase for SAML and Kafka configurations
  • Added SAML configuration to AdminConfiguration struct

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/config/types.go Fixed Kafka configuration typo, standardized YAML tags to camelCase, and added SAML config to AdminConfiguration
pkg/logging/kafka.go Updated reference to use corrected BootstrapServer field name
pkg/config/flags.go Updated flag destination to use corrected BootstrapServer field name
cmd/tls/main.go Renamed function and extracted YAML config type to constant, added unmarshal step
cmd/api/main.go Renamed function, extracted YAML config type to constant, added unmarshal step, and corrected flag initialization call
cmd/admin/main.go Renamed function, extracted YAML config type to constant, and added unmarshal step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@javuto javuto merged commit 441e666 into main Nov 25, 2025
55 checks passed
@javuto javuto deleted the yaml-config-admin branch November 25, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ configuration Configuration related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants