Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the deployment provisioning script from using multiple JSON configuration files to a single YAML configuration file per service. The changes involve updating data types for port numbers from strings to integers across the codebase and modifying the deployment scripts to use yq for YAML manipulation instead of sed for JSON template substitution.
- Updates port-related configuration fields from string to int type throughout the codebase
- Replaces JSON configuration templates with YAML files and updates deployment scripts accordingly
- Updates PostgreSQL and Go version references in provision script
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tls.yml | New YAML configuration file for osctrl-tls service with all service parameters |
| pkg/settings/settings.go | Converts port integers to strings when storing in JSON settings |
| pkg/config/types.go | Changes Port fields from string to int in YAML configuration structs |
| pkg/config/flags.go | Updates CLI flags to use IntFlag instead of StringFlag for port parameters |
| deploy/provision.sh | Refactors to use single YAML config file and yq tool; updates PostgreSQL/Go versions |
| deploy/lib.sh | Simplifies configuration functions to use yq for direct YAML manipulation |
| deploy/config/service.json | Removes JSON template file |
| deploy/config/redis.json | Removes JSON template file |
| deploy/config/jwt.json | Removes JSON template file |
| deploy/config/db.json | Removes JSON template file |
| cmd/tls/main.go | Updates port concatenation to use strconv.Itoa for integer conversion |
| cmd/cli/main.go | Changes db-port flag from StringFlag to IntFlag |
| cmd/api/main.go | Updates service listener to use integer port with strconv.Itoa |
| cmd/admin/main.go | Updates service listener to use integer port with strconv.Itoa |
| cmd/admin/handlers/utils.go | Adds string-to-int conversion for port values from settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
provision.shprovision.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up #754 to utilize the single YAML configuration file in the
provision.shdeployment script