Prevent crash in osctrl-api and other fixes around configuration#760
Merged
Prevent crash in osctrl-api and other fixes around configuration#760
osctrl-api and other fixes around configuration#760Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents a crash in osctrl-api by properly initializing nested configuration structures, updates default network listeners to use localhost instead of all interfaces, and fixes the DEB package generation script to reference YAML configuration files.
Key Changes
- Added proper initialization of
LoggerandCarvernested structs inosctrl-apito prevent nil pointer crashes - Changed default listener addresses from
0.0.0.0to127.0.0.1for improved security - Updated all file paths to use
./prefix for consistency
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/config/types.go | Added Carver field to APIConfiguration struct |
| pkg/config/flags.go | Updated default values for listeners, file paths, and added JWT expiration constant |
| deploy/config/tls.yml | Updated listener addresses and file paths to use localhost and ./ prefix |
| deploy/config/api.yml | Updated listener addresses, file paths, and expanded logger/carver configuration with all nested fields |
| deploy/config/admin.yml | Updated listener addresses, file paths, and fixed Kafka connection timeout |
| deploy/cicd/deb/generate-deb-package.sh | Fixed script to copy YAML config files instead of JSON |
| cmd/api/utils.go | Added missing fields to service parameters mapping |
| cmd/api/main.go | Properly initialized nested logger and carver configuration structs |
| admin.yml | Removed root-level admin.yml file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple fixes around the single YAML configuration file:
osctrl-apidue to struct not properly initialized127.0.0.1for the default listeners