Skip to content

Prevent crash in osctrl-api and other fixes around configuration#760

Merged
javuto merged 1 commit intomainfrom
fix-local-files-yaml
Dec 22, 2025
Merged

Prevent crash in osctrl-api and other fixes around configuration#760
javuto merged 1 commit intomainfrom
fix-local-files-yaml

Conversation

@javuto
Copy link
Collaborator

@javuto javuto commented Dec 22, 2025

Multiple fixes around the single YAML configuration file:

  • Prevent crash in osctrl-api due to struct not properly initialized
  • Utilize 127.0.0.1 for the default listeners
  • Fix for the DEB package creation in CICD

@javuto javuto requested a review from Copilot December 22, 2025 22:47
@javuto javuto added osctrl-api osctrl-api related changes cicd CICD related issues ⚙️ configuration Configuration related issues labels Dec 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents a crash in osctrl-api by properly initializing nested configuration structures, updates default network listeners to use localhost instead of all interfaces, and fixes the DEB package generation script to reference YAML configuration files.

Key Changes

  • Added proper initialization of Logger and Carver nested structs in osctrl-api to prevent nil pointer crashes
  • Changed default listener addresses from 0.0.0.0 to 127.0.0.1 for improved security
  • Updated all file paths to use ./ prefix for consistency

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/config/types.go Added Carver field to APIConfiguration struct
pkg/config/flags.go Updated default values for listeners, file paths, and added JWT expiration constant
deploy/config/tls.yml Updated listener addresses and file paths to use localhost and ./ prefix
deploy/config/api.yml Updated listener addresses, file paths, and expanded logger/carver configuration with all nested fields
deploy/config/admin.yml Updated listener addresses, file paths, and fixed Kafka connection timeout
deploy/cicd/deb/generate-deb-package.sh Fixed script to copy YAML config files instead of JSON
cmd/api/utils.go Added missing fields to service parameters mapping
cmd/api/main.go Properly initialized nested logger and carver configuration structs
admin.yml Removed root-level admin.yml file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@javuto javuto merged commit 071c774 into main Dec 22, 2025
55 checks passed
@javuto javuto deleted the fix-local-files-yaml branch December 22, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cicd CICD related issues ⚙️ configuration Configuration related issues osctrl-api osctrl-api related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants