Don't allow tunnel to hang open#63
Open
scally wants to merge 1 commit intojmreidy:masterfrom
scally:fix-tunnel-open-breakage
Open
Don't allow tunnel to hang open#63scally wants to merge 1 commit intojmreidy:masterfrom scally:fix-tunnel-open-breakage
scally wants to merge 1 commit intojmreidy:masterfrom
scally:fix-tunnel-open-breakage
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a tunnel fails to open, hard crash it to keep it from hanging in the open state.
We keep having an issue where opening a tunnel to sauce fails. Upon this failure, the grunt task remains stuck and never exits without being manually killed.
Because the
scbinary fails with a nonzero exit code, theexitevent never fires onthis.proc. The call toproc.kill()also fails because the child process has already exited by the time any error is detected.