Skip to content

Switch from PhantomJS to headless Chrome #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmuheim wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Switch from PhantomJS to headless Chrome #101

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d184440
Refactor
jmuheim Jun 9, 2018
3e5e59c
Refactor, fix specs
jmuheim Jun 9, 2018
de2efe3
Refactor, fix specs
jmuheim Jun 9, 2018
6dd6787
More cleanup
jmuheim Jun 9, 2018
badd05d
Fixed deprecation warning
gurix Jun 9, 2018
d30ebdf
Adjusted some rubocop settings
gurix Jun 9, 2018
f086685
Fixed broken test
gurix Jun 9, 2018
edbce84
Remove Poltergeist hack
gurix Jun 9, 2018
b1463d6
capybara gem missing for travis
gurix Jun 9, 2018
b5a5c5e
Added chrome addon to travis
gurix Jun 10, 2018
557a98d
Adde more settings to run chrome driver
gurix Jun 10, 2018
d3f7a7e
Deprecation warning disapears when remove sqlite 3
gurix Jun 11, 2018
c665940
fixed typo
gurix Jun 11, 2018
ef1a817
Added sudo required
gurix Jun 11, 2018
5d4280f
travis do not find the chromedriver, probably it helps to use chromed…
gurix Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
AllCops:
Copy link
Copy Markdown
Owner Author

@jmuheim jmuheim Jun 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used Rubocop some time ago, but didn't remember I'm still using it.

It's good to have it, I think. But line length and stuff sometimes seems a pain in the ass, especially in specs.

Copy link
Copy Markdown
Collaborator

@gurix gurix Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True but for some blocks as it, scenario and so on you can disable the line length. Feel free to change it as soon as it disturbs you (not tested):

LineLength:
  Enabled: true
  Max: 160
  ExcludedMethods:
    - describe
    - context
    - scenario
    - it
    - feature
Metrics/BlockLength:
  ExcludedMethods:
    - describe
    - context
    - scenario
    - it
    - feature

Exclude:
- db/schema.rb
FrozenStringLiteralComment:
Enabled: false
LineLength:
Enabled: true
Max: 160
Rails:
Enabled: true