Simple validation for render method#137
Open
eagleloid wants to merge 2 commits intojnordberg:masterfrom
Open
Conversation
If 'render' is ran with no frames, @running will remain 'True' until the class is reconstructed.
Set running variable to FALSE at the end of the 'finishRendering' method so user can render again without having to reconstruct class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added a validation check for the render method in case user attempt to render without any frames. Allows the user to call it again without having to reconstruct the class.
Also set the
@runningvariable tofalseafter 'finished' is emitted in thefinishRenderingmethod for similar reason as above.