-
Notifications
You must be signed in to change notification settings - Fork 76
Changes in functions for generation and an example of vertical plot with additional charts #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ennanco
wants to merge
24
commits into
jnothman:master
Choose a base branch
from
ennanco:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
83a15bb
changes in functions generate_samples and generate_counts to allow ge…
ennanco 5dab608
added unitary tests for generate_samples and generate_counts funtions
ennanco 3eb9c65
Repaired problems with some tests
ennanco e40d6b9
Repaired several examples due to the inclussion of the new generate_s…
ennanco 7f5f918
Change the string format to make it compatible with Python v2
ennanco e0d9df0
Adding compatibility in generate_samples for python v2
ennanco 4e18668
Adding adaptations to made it retrocompatible with the examples
ennanco b0c9c7b
Fixing style
ennanco 3374d0d
Fixing test_data.py according to python style sheet
ennanco 9c546e0
Fixing indentation
ennanco 7805d3f
Fixing indentation
ennanco 4cab536
Fixing doctring in generete_counts and changing generate_samples for …
ennanco b1d0ec6
Fixing spacing style in some comments
ennanco f64fb19
Adding unitary test for generate_data
ennanco 5443acb
Adding unitary test for generate_data
ennanco 5731bc6
Adding unitary test for generate_data
ennanco ede49b5
Merge branch 'jnothman:master' into master
ennanco 062e337
Update upsetplot/data.py
ennanco 3d884c4
Update upsetplot/data.py
ennanco b000f15
Update upsetplot/data.py
ennanco 684be8c
Update upsetplot/data.py
ennanco ce55bd0
Update examples/plot_vertical.py
ennanco 35ef9bf
Merge branch 'jnothman:master' into master
ennanco 746f679
Merge branch 'jnothman:master' into master
ennanco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think counting is meaningful for the extra columns. Maybe we should use a different aggregate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we shouldn't offer this functionality in
generate_counts
, making things somewhat simpler.