Skip to content

Conversation

@MohamedSonata
Copy link
Contributor

Description

This PR fixes the CMake warning After update (Desktop Development with c++) Components (c++ CMake tools for Windows) related to CMP0175 policy and improves the overall CMake configuration using modern practices.

Changes

  • Added proper handling of CMP0175 policy
  • Removed deprecated usage of DEPENDS keyword in add_custom_command(TARGET)
  • Improved organization and readability of CMake configuration
  • Added better feedback for dependency download process
  • Structured the build configuration using modern CMake practices

Testing

  • Tested with CMake 3.15+
  • Verified that the warning about CMP0175 no longer appears
  • Confirmed that all dependencies are still properly downloaded and configured
  • Verified that the plugin builds and functions correctly

Related Issues

Fixes the CMake warning:
CMake Warning (dev) at flutter/ephemeral/.plugin_symlinks/webview_windows/windows/CMakeLists.txt:34 (add_custom_command): The following keywords are not supported when using add_custom_command(TARGET): DEPENDS.

Thanks ...

…verall CMake configuration using modern practices.
@jnschulze
Copy link
Owner

lgtm, thanks!

@jnschulze jnschulze merged commit ed81bbe into jnschulze:main Jun 26, 2025
1 check passed
@pankaj-nikam
Copy link

Hi, @jnschulze any plan on releasing this to pub?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants