Update speed-sensitive-volume.sh#17
Open
neon-dev wants to merge 2 commits intojnuyens:masterfrom
neon-dev:patch-1
Open
Update speed-sensitive-volume.sh#17neon-dev wants to merge 2 commits intojnuyens:masterfrom neon-dev:patch-1
neon-dev wants to merge 2 commits intojnuyens:masterfrom
neon-dev:patch-1
Conversation
neon-dev
commented
Oct 22, 2019
neon-dev
commented
- optimized sleep times - more responsive volume adjustment shouldn't increase overall car api calls by much, due to additional if clauses
- added config value for speed steps (now 8 mph instead of 10 mph) and reduced volume increment to smoothen things out
- added config value for minimum speed at which volume control will start
- added speed diff condition to avoid corner cases where volume could constantly jump between two values
- simplified value conversions and getting/setting of data values
- fixed volume 0 didn't stay at 0
- removed min volume config (min is one increment above volume level 0 now)
- removed max volume config (sense of this script is to keep volume subjectively at the same level)
- reread volume after adjusting it to accomodate for capping and rounding by mcu
- optimized sleep times - more responsive volume adjustment shouldn't increase overall car api calls by much, due to additional if clauses - added config value for speed steps (now 8 mph instead of 10 mph) and reduced volume increment to smoothen things out - added config value for minimum speed at which volume control will start - added speed diff condition to avoid corner cases where volume could constantly jump between two values - simplified value conversions and getting/setting of data values
Author
|
I just realized apps run in a chroot jail (i don't use freedomev), so the lv/sdv commands are maybe not accessible from this environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.