Skip to content

Support Mill 1.0.0-RC1#114

Merged
joan38 merged 1 commit intomainfrom
mill-1-rc
May 27, 2025
Merged

Support Mill 1.0.0-RC1#114
joan38 merged 1 commit intomainfrom
mill-1-rc

Conversation

@joan38
Copy link
Owner

@joan38 joan38 commented May 27, 2025

No description provided.

@joan38 joan38 requested a review from Copilot May 27, 2025 04:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for Mill 1.0.0-RC1 by updating test modules, build definitions, and CI settings to target the new release candidate.

  • Switch test runners from clientServerMode to daemonMode
  • Bump cross‐build versions, Scala targets, artifacts, and migrate from T(...) to Task(...)
  • Update CI to run tests and publish for 1.0.0-RC1

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mill-git/test/src/com/goyeau/mill/git/Tester.scala Replaced clientServerMode = true with daemonMode = true in IntegrationTester setup
mill-git/test/src/com/goyeau/mill/git/ExampleTests.scala Replaced clientServerMode = true with daemonMode = true in ExampleTester.run call
mill-git/test/resources/publish/build.mill Updated sample build to point at 0.2.7-...-SNAPSHOT via comment metadata
mill-git/test/resources/docker/build.mill Added snapshot repository and dependencies comments for Docker example
mill-git/test/resources/custom/build.mill Migrated T(GitVersionModule.version()()) to Task(GitVersionModule.version()())
mill-git/src/com/goyeau/mill/git/GitVersionModule.scala Removed unused mill.define.Command import
build.mill Bumped cross versions to "1.0.0-RC1", updated Scala versions, dependency artifacts, launcher main class
.github/workflows/ci.yml Adjusted CI to run tests and publish for Mill 1.0.0-RC1
Comments suppressed due to low confidence (2)

.github/workflows/ci.yml:23

  • CI no longer runs the tests for the previously supported 0.12.0 cross-build, which could let regressions slip in older versions—consider re-adding __[0.12.0].test to the matrix.
          ./mill __.checkStyle + __[1.0.0-RC1].test + __.publishLocal

build.mill:38

  • There appears to be an extra closing parenthesis on the compileIvyDeps match block, which will cause a compilation error—remove one of the ) to correctly close the expression.
      ))

@joan38 joan38 force-pushed the mill-1-rc branch 8 times, most recently from 9611ec7 to 94df81a Compare May 27, 2025 19:04
@joan38 joan38 merged commit 788323f into main May 27, 2025
1 check passed
@joan38 joan38 deleted the mill-1-rc branch May 27, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments