Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for Mill 1.0.0-RC1 by updating test modules, build definitions, and CI settings to target the new release candidate.
- Switch test runners from
clientServerModetodaemonMode - Bump cross‐build versions, Scala targets, artifacts, and migrate from
T(...)toTask(...) - Update CI to run tests and publish for
1.0.0-RC1
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mill-git/test/src/com/goyeau/mill/git/Tester.scala | Replaced clientServerMode = true with daemonMode = true in IntegrationTester setup |
| mill-git/test/src/com/goyeau/mill/git/ExampleTests.scala | Replaced clientServerMode = true with daemonMode = true in ExampleTester.run call |
| mill-git/test/resources/publish/build.mill | Updated sample build to point at 0.2.7-...-SNAPSHOT via comment metadata |
| mill-git/test/resources/docker/build.mill | Added snapshot repository and dependencies comments for Docker example |
| mill-git/test/resources/custom/build.mill | Migrated T(GitVersionModule.version()()) to Task(GitVersionModule.version()()) |
| mill-git/src/com/goyeau/mill/git/GitVersionModule.scala | Removed unused mill.define.Command import |
| build.mill | Bumped cross versions to "1.0.0-RC1", updated Scala versions, dependency artifacts, launcher main class |
| .github/workflows/ci.yml | Adjusted CI to run tests and publish for Mill 1.0.0-RC1 |
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:23
- CI no longer runs the tests for the previously supported 0.12.0 cross-build, which could let regressions slip in older versions—consider re-adding
__[0.12.0].testto the matrix.
./mill __.checkStyle + __[1.0.0-RC1].test + __.publishLocal
build.mill:38
- There appears to be an extra closing parenthesis on the
compileIvyDepsmatch block, which will cause a compilation error—remove one of the)to correctly close the expression.
))
9611ec7 to
94df81a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.