Skip to content

feat: update RequiredValidator to support validate empty Map, List, S… #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonpham wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: update RequiredValidator to support validate empty Map, List, S… #460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61cbb46
feat: update RequiredValidator to support validate empty Map, List, S…
simonpham Aug 13, 2024
54cc8c5
refactor: remove redundant checks
simonpham Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/src/validators/required_validator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@

if (control.value == null) {
return error;
} else if (control.value is String) {
return (control.value as String).trim().isEmpty ? error : null;
} else if (control.value case String string) {
return string.trim().isEmpty ? error : null;
} else if (control.value case Map value) {
return value.isEmpty ? error : null;
} else if (control.value case Iterable value) {
return value.isEmpty ? error : null;

Check warning on line 22 in lib/src/validators/required_validator.dart

View check run for this annotation

Codecov / codecov/patch

lib/src/validators/required_validator.dart#L19-L22 

Added lines #L19 - L22 were not covered by tests
}

return null;
Expand Down
Loading