Add namespace to helm (template) - helm issue 3553#184
Open
oernii wants to merge 2 commits intojoe-elliott:masterfrom
Open
Add namespace to helm (template) - helm issue 3553#184oernii wants to merge 2 commits intojoe-elliott:masterfrom
oernii wants to merge 2 commits intojoe-elliott:masterfrom
Conversation
Owner
|
A very similar PR was posted here: #180 I just want to confirm that this will not negatively impact folks who upgrade their helm chart. Will this reinstall cert-exporter in a new namespace? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm only adds "namespace" to "helm template" and helm dry-run if it is specified in the original teplate. This adds the namespace.
Upstream reason:
helm/helm#3553 (comment)