Skip to content

add seq label to storage_type#3

Open
stefanmonkey wants to merge 4 commits intojoe-pll:masterfrom
stefanmonkey:origin
Open

add seq label to storage_type#3
stefanmonkey wants to merge 4 commits intojoe-pll:masterfrom
stefanmonkey:origin

Conversation

@stefanmonkey
Copy link
Contributor

@stefanmonkey stefanmonkey commented Nov 29, 2017

add seq label into storage_type in func collectStorageInfo to fix issue #2

after add , metrics output like

# HELP minio_storage_storage_type Minio backend storage type used
# TYPE minio_storage_storage_type gauge
minio_storage_storage_type{seq="0",type="Erasure"} 2
minio_storage_storage_type{seq="1",type="Erasure"} 2
minio_storage_storage_type{seq="2",type="Erasure"} 2
minio_storage_storage_type{seq="3",type="Erasure"} 2

@joe-pll
Copy link
Owner

joe-pll commented Dec 21, 2017

Hi, after reading your PR I realised that the storageInfo are the same for all the servers. I sligthly modified the code. Could you please try to build from the branch 'server-data-info-fix' and tell me if you're still experiencing the problem?
I started a 4 servers (16 exports) as you suggested to do and it works for me.

If it works for you too i'll merge it and build a new docker image. After that, can you please create another PR with the grafana dashboards?

@stefanmonkey
Copy link
Contributor Author

@joe-pll I have create pr #5.

@rustup
Copy link

rustup commented Feb 28, 2018

Great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants