This repository was archived by the owner on Dec 10, 2019. It is now read-only.
Add abitily to tunnel HTTP over HTTP proxy #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy support built into the axios library was not able to handle configurations where HTTPS traffic is passed through an HTTP proxy server. This commit adds support for using the 'tunnel' library to support HTTPS-over-HTTP proxy configurations. - Update config.sample.json with an example HTTPS proxy tunnel configuration. - Update README.md to document added settings. - Update githubservice.js to optionally support proxy tunnel. - Use beta version of axios as this is required for tunnel. Signed-off-by: Jim Conner <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy support built into the axios library was not able to handle configurations where HTTPS traffic is passed through an HTTP proxy server.
This commit adds support for using the 'tunnel' library to support HTTPS-over-HTTP proxy configurations.