This repository was archived by the owner on Feb 4, 2023. It is now read-only.
Open
Conversation
added 3 commits
April 11, 2019 12:50
It's more convenient to have the buildtar step SKIP_DEVICE to generate the tar then use the --archive option in the second step to do the actual androdeb setup of the device. Also since INSTALL_BCC is now performed when creating the debian image we can always tar the deb.tar.gz without having to copy anything from the device. Also drop creating a zip version of the generated tarred file. Signed-off-by: Qais Yousef <qais.yousef@arm.com>
When --buildtar is specified the headers are downloaded and used where in reality we don't care about kheaders at this stage. Since DOWNLOAD=0 when --buildtar is specified, used that to control whether kheaders should be downloaded too. Signed-off-by: Qais Yousef <qais.yousef@arm.com>
I found myself needing to install these two packages regularly. The first to collect traces and teh 2nd to extract /proc/kheaders.tar.xz. So always make them available by default. Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Author
|
@joelagnel hopefully this PR should be trivial to look at if you can find sometime? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of fixes to make --buildtar option more convenient. Hopefully the commit messages are descriptive enough.