Avoid logging errors by mocking global flags#2
Open
jtcohen6 wants to merge 1 commit intojoellabes:mainfrom
Open
Avoid logging errors by mocking global flags#2jtcohen6 wants to merge 1 commit intojoellabes:mainfrom
jtcohen6 wants to merge 1 commit intojoellabes:mainfrom
Conversation
joellabes
pushed a commit
that referenced
this pull request
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where dbt encounters a seed that is >1 MB in size, it will fire an event that is either
warn_or_error, depending on the value of the globalWARN_ERRORflag.Mock the global
Flagsby pretending that this is thelistcommand with default CLI options.dbt-core will still write its logging events to stdout (the terminal running
streamlit). A future enhancement could try playing withcontextlib.redirect_stdoutto show these log messages in the streamlit app UI instead.