Skip to content

Only log about graph closing if it is not a zero operation. #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ml86 merged 2 commits into from
Jul 25, 2025
Merged

Only log about graph closing if it is not a zero operation. #341

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1817109
Only log about graph closing if it is not a zero operation.
ml86 Jul 24, 2025
b78af55
Update core/src/main/scala/flatgraph/Graph.scala
ml86 Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions core/src/main/scala/flatgraph/Graph.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,16 @@ class Graph(val schema: Schema, val storagePathMaybe: Option[Path] = None) exten
def isClosed: Boolean = closed

override def close(): Unit = {
logger.debug("closing graph")
this.closed = true

for {
storagePath <- storagePathMaybe
if hasChangedSinceOpen
} Serialization.writeGraph(this, storagePath)

logger.info("closed graph")
} {
logger.debug(s"closing graph: start writing changes to $storagePath")
Serialization.writeGraph(this, storagePath)
logger.info(s"closed graph at $storagePath}")
}
}

override def toString(): String =
Expand Down