[C#] Ast structure for CoalesceExpression#4788
Open
karan-batavia wants to merge 2 commits intojoernio:masterfrom
Open
[C#] Ast structure for CoalesceExpression#4788karan-batavia wants to merge 2 commits intojoernio:masterfrom
CoalesceExpression#4788karan-batavia wants to merge 2 commits intojoernio:masterfrom
Conversation
DavidBakerEffendi
suggested changes
Jul 22, 2024
| val leftAst = astForExpression(createDotNetNodeInfo(coalesceExpression.json(ParserKeys.Left))) | ||
| val rightAst = astForExpression(createDotNetNodeInfo(coalesceExpression.json(ParserKeys.Right))) | ||
|
|
||
| leftAst ++ rightAst |
Contributor
There was a problem hiding this comment.
We should probably add a <operator>.coalesce so that we can embed the correct semantics
Contributor
There was a problem hiding this comment.
Should this not also be a callNode or something similar with the operator you suggested above?
Contributor
There was a problem hiding this comment.
@AndreiDreyer Yes, something like callAst(callNode, leftAst ++ rightAst)
| |} | ||
| |""".stripMargin) | ||
|
|
||
| "resolve methodFullName" in { |
Contributor
There was a problem hiding this comment.
I would like AST tests here too, please. Specifically to verify the coalescing operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.