[pysrc2cpg] Avoid tmp variable creation in for non complex receivers. #5719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far the python frontend emitted tmp variables in the context of call site lowering if the `<x>` in a `<x>.y()` call was anything other than an identifier/name. Now we also avoid emitting tmp variables if `<x>` is a member access chain. E.g. `x.y.z()`. This leads to less clutter and better alias handling.
maltek
approved these changes
Dec 9, 2025
Contributor
maltek
left a comment
maltek
left a comment
There was a problem hiding this comment.
Maybe rename mayHaveSideEffects to assumeNoSideEffects or so? In principle, python does support computed getters/setters that can have side effects. To be clear, I'm not saying we should revisit our long-standing assumption that such getters/setters actually behave like a simple field access. Just that we should spell this assumption out more clearly here.
Contributor
Author
|
Fair point, i will rename it in a follow up PR to keep this here small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the python frontend emitted tmp variables in the context of call
site lowering if the
<x>in a<x>.y()call was anything other thanan identifier/name. Now we also avoid emitting tmp variables if
<x>isa member access chain. E.g.
x.y.z(). This leads to less clutter andbetter alias handling.