-
Notifications
You must be signed in to change notification settings - Fork 908
Python 3 Compatibility #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3.3 and 3.4 should be added to the travis matrix, potentially as allowable failures if they're failing. But currently this branch is failing. :s |
Yeh I noticed that. About to push changes which will make travis build for 3.4 and 3.3 |
I've done a basic update to the library to begin getting it to be python3 compatible. A lot of upstream projects still rely on this unfortunately and their communities are not willing to change to oauthlib. This will help to prolong the inevitable.
Bit of work to do before this can be accepted. Since I ran the tests on the original PR looks like a bunch of things have changed. |
I have a small commit you can cherry pick to fix this (I can make a PR as I forgot to turn on travis, but it passes locally). all tests pass on python2 (2.6 and 2.7) and python 3.... except one (which fails in master too).
Edit: Scratch that, this PR still fails on 50/72 tests in python 3. :( |
Hi guys.. I'm looking to use oauth2 with Python 3.4 |
Projects only been alive for a couple days after being dead for about 4 years so we're getting there! Definitely keep an eye on this PR or even feel free to contribute... |
Thanks @jaitaiwan. I'm a rookie so may not be able to help yet.. but looking out for you guys to pull this through 👍 |
@jaitaiwan should we move this to a feature branch so others can help out? |
I created branch |
I think the best bet is to get #142 working, I had a little go (we're all re-inventing the wheel otherwise). |
Yup I'm closing this one out in favour of #142 |
I'm not sure these changes ensure FULL compatibility but I believe running this should have no errors in 3 now. Also not sure if this breaks backwards compatibility...