allow setting alarm presets at compile time#477
Open
mcguirepr89 wants to merge 1 commit intojoeycastillo:mainfrom
Open
allow setting alarm presets at compile time#477mcguirepr89 wants to merge 1 commit intojoeycastillo:mainfrom
mcguirepr89 wants to merge 1 commit intojoeycastillo:mainfrom
Conversation
Owner
|
Hi and thanks for this pull request! Pull requests against this repository are on hold during a refactor of Movement to support new hardware. Still I think this is a promising addition and I'd like to look at it at a later date. Sorry if it doesn't get attention right away! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a user to create preset alarms that are setup at compile time. This allows users to forego recreating their alarms anytime they re-compile their firmware. I've found it helpful and suspect there may be others who also find this helpful.
Alarm presets are set in
alarm_face.hand look something like this: