Skip to content

Conversation

@jogold
Copy link
Owner

@jogold jogold commented Dec 30, 2025

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @jogold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's development setup by migrating its package manager from Yarn to pnpm and converting the Projen configuration to TypeScript. These changes streamline dependency management, improve build performance, and align the project with current best practices for TypeScript-based Projen projects, ensuring a more robust and efficient development workflow.

Highlights

  • Package Manager Migration: The project has transitioned from using Yarn to pnpm for dependency management, aiming for improved performance and disk space efficiency.
  • Projen Configuration Update: The Projen configuration file has been converted from JavaScript (.projenrc.js) to TypeScript (.projenrc.ts), enhancing type safety and developer experience for project configuration.
  • Build and Linting Task Adjustments: Project tasks for synthesizing, linting, installing dependencies, and creating language bindings have been updated to reflect the switch to pnpm and the TypeScript-based Projen configuration.
  • Dependency Version Updates: Several development dependencies, including AWS SDK clients, ESLint plugins, Jest, and Projen itself, have been updated to their latest minor versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (4)
    • .github/workflows/build.yml
    • .github/workflows/pull-request-lint.yml
    • .github/workflows/release.yml
    • .github/workflows/upgrade-master.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project from yarn to pnpm as the package manager and converts the .projenrc.js configuration file to TypeScript. The changes are mostly auto-generated by projen and appear correct, reflecting the package manager switch across various configuration files and scripts. I've identified a potential issue in a generated script command within .projen/tasks.json that could cause errors, and a minor opportunity for code cleanup in .projenrc.ts to enhance maintainability by removing redundant properties. Overall, this is a solid chore update.

},
"env": {
"PATH": "$(npx -c \"node --print process.env.PATH\")"
"PATH": "$(pnpm -c exec \"node --print process.env.PATH\")"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The command pnpm -c exec ... is incorrect. The -c flag (short for --shell-mode) is an option for pnpm exec, not for pnpm itself. The correct invocation should be pnpm exec -c .... This is likely a generation bug in projen's pnpm support, and as it stands, it will probably cause an error when tasks are run.

Suggested change
"PATH": "$(pnpm -c exec \"node --print process.env.PATH\")"
"PATH": "$(pnpm exec -c \"node --print process.env.PATH\")"

@jogold jogold enabled auto-merge (squash) December 30, 2025 18:20
@jogold jogold changed the title chore: use pnpm chore: .projenrc.ts Dec 30, 2025
@jogold jogold merged commit 6069fb8 into master Dec 30, 2025
8 of 12 checks passed
@jogold jogold deleted the pnpm branch December 30, 2025 18:59
jogold added a commit that referenced this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants