-
Notifications
You must be signed in to change notification settings - Fork 14
chore: .projenrc.ts #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: .projenrc.ts #323
Conversation
Summary of ChangesHello @jogold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's development setup by migrating its package manager from Yarn to pnpm and converting the Projen configuration to TypeScript. These changes streamline dependency management, improve build performance, and align the project with current best practices for TypeScript-based Projen projects, ensuring a more robust and efficient development workflow. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates the project from yarn to pnpm as the package manager and converts the .projenrc.js configuration file to TypeScript. The changes are mostly auto-generated by projen and appear correct, reflecting the package manager switch across various configuration files and scripts. I've identified a potential issue in a generated script command within .projen/tasks.json that could cause errors, and a minor opportunity for code cleanup in .projenrc.ts to enhance maintainability by removing redundant properties. Overall, this is a solid chore update.
.projen/tasks.json
Outdated
| }, | ||
| "env": { | ||
| "PATH": "$(npx -c \"node --print process.env.PATH\")" | ||
| "PATH": "$(pnpm -c exec \"node --print process.env.PATH\")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command pnpm -c exec ... is incorrect. The -c flag (short for --shell-mode) is an option for pnpm exec, not for pnpm itself. The correct invocation should be pnpm exec -c .... This is likely a generation bug in projen's pnpm support, and as it stands, it will probably cause an error when tasks are run.
| "PATH": "$(pnpm -c exec \"node --print process.env.PATH\")" | |
| "PATH": "$(pnpm exec -c \"node --print process.env.PATH\")" |
No description provided.