-
Notifications
You must be signed in to change notification settings - Fork 14
feat(ssl-server-test): use durable Lambda function #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jogold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the SslServerTest construct to use a durable Lambda function instead of a Step Function state machine, which simplifies the architecture. The changes look good overall, and the dependencies have been updated accordingly. I've found a bug where a new property is not being used and a potential robustness issue in the new Lambda function. I've also spotted a minor typo in the documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully refactors the SslServerTest to use a durable Lambda function with the @aws/durable-execution-sdk-js instead of a Step Function. This simplifies the architecture. The update to SSL Labs API v4 and the associated breaking change requiring a registrationEmail are clearly communicated. The code changes are well-implemented, and the new tests for the durable lambda are comprehensive. I have a few suggestions to improve code clarity and a question about a potential workaround related to the CDK version upgrade.
Use a durable Lambda function instead of a Step Function.
Switch to the API v4. Now requires an registered email.
BREAKING CHANGE:
SslServerTestnow requires aregistrationEmailto run.