feat(static-website): use CloudFront functions for rewrite and redirect

[jogold]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jogold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the static website construct by replacing Lambda@Edge functions with AWS CloudFront Functions for both URI rewriting and domain redirection. This change aims to optimize performance and reduce operational overhead by leveraging the lightweight and cost-effective nature of CloudFront Functions for common edge computing tasks, resulting in a more streamlined and efficient deployment for static websites.

Highlights

• Migration to CloudFront Functions for Rewrites: The static website construct now utilizes AWS CloudFront Functions for handling URI rewrites, specifically for requests without file extensions, directing them to '/index.html'. This replaces the previous Lambda@Edge implementation for this functionality.
• CloudFront Functions for Redirects: The redirect mechanism has been refactored to use CloudFront Functions instead of the HttpsRedirect pattern. A new CloudFront Distribution is created for redirects, with a CloudFront Function performing 301 permanent redirects to the target domain.
• Removal of Lambda@Edge Components: The OriginRequestFunction and its associated Lambda@Edge handler file (origin-request.edge-lambda.ts) have been removed, streamlining the architecture by consolidating edge logic into CloudFront Functions.
• Type Safety and Enum Usage: Updated the recordType for HTTPS records in Route53 to use the route53.RecordType.HTTPS enum, improving type safety. Similarly, the httpVersion property in the URL shortener construct was updated to use cloudfront.HttpVersion.HTTP2_AND_3.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the StaticWebsite construct to replace Lambda@Edge functions with CloudFront Functions for both URI rewriting (e.g., redirecting to index.html for paths without extensions) and HTTP redirects. The changes involve removing the OriginRequestFunction and its associated files, introducing inline CloudFront Functions for viewer requests, and reimplementing the HTTPS redirect logic without using the aws-route53-patterns construct. Additionally, minor syntax improvements were made to use cloudfront.HttpVersion.HTTP2_AND_3 and route53.RecordType.HTTPS enums. Review comments highlight issues with the new redirect implementation, specifically the lack of a default redirect to the hosted zone's name and the use of invalid characters (dots) in Route 53 record construct IDs, which need to be sanitized. Another comment points out a potential conflict where the new default viewer-request CloudFront Function could clash with user-provided viewer-request Lambda@Edge functions, suggesting conditional application and documentation updates. Finally, a more robust regex for detecting file extensions in the rewrite function was recommended.

[gemini-code-assist]

The regex /\.[a-zA-Z0-9]+$/ to detect a file extension is a bit restrictive. It won't match extensions containing characters other than letters and numbers. A more robust approach would be to allow any character except a slash in the extension part.

  const hasExtension = /\.[^/]+$/.test(uri);