fix(static-website): incorrect regex for URL rewrite

[jogold]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jogold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the URL rewrite logic for static websites was using an incorrect regular expression to determine if a URI contained a file extension. By properly escaping the dot character in the regex, the system will now correctly identify URIs that should be rewritten to index.html, improving the robustness of static site routing.

Highlights

• Regex Correction: The regular expression used within the rewriteFunctionCode to detect file extensions in URIs was updated. The . character, which acts as a wildcard, was incorrectly unescaped. It has been corrected to \. to match a literal dot, ensuring accurate file extension detection.
• Formatting Improvements: Minor formatting adjustments were made by removing empty lines within template literals in src/static-website/index.ts and corresponding snapshot test files.
• Snapshot Update: The snapshot test file test/static-website/__snapshots__/static-website.test.ts.snap was updated to reflect the corrected regular expression and formatting changes in the generated CloudFront function code.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an incorrect regular expression used for URL rewriting in a CloudFront function. The backslash before the dot was not properly escaped in the template literal, causing the regex to match any character instead of a literal dot. The fix correctly escapes the backslash. The PR also includes minor stylistic fixes by removing trailing semicolons from the inlined function code.

My review includes a suggestion to make the regular expression more robust to handle a wider range of valid file extensions.

[gemini-code-assist]

While the fix to escape the backslash is correct, the regex /[a-zA-Z0-9]+/ for the file extension is quite restrictive. It would not match extensions containing characters like underscores or hyphens.

A more robust approach would be to use /\.[^/.]+$/. This regex will match a dot followed by one or more characters that are not a forward slash or a dot, at the end of the string. This makes it more future-proof for various asset types.

For example, it would correctly handle paths like:

• /assets/image.svg
• /assets/font-v2.woff2
• /archive.tar.gz (matching .gz)

And correctly ignore paths like:

• /users/123
• /about/
• /path/ending/with/a.

Note: After applying this change, you will need to update the test snapshots.

Suggested change

	const hasExtension = /\\.[a-zA-Z0-9]+$/.test(uri);
	const hasExtension = /\.[^/.]+$/.test(uri);