You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The former is used to build the code and create a Docker image. The latter contains the configuration (exposing FUSE from Docker is a bit tricky) to run a container from the previously built image which will mount Sintel on /tmp/, as described in docs. Just do docker-compose up as stated in docs.
Using both files enabled me to develop and test #69 without needing to install any development libs or tools in my machine.
Optionally, the Dockerfile can also be used to create a public Docker image built from source to use as a distribution method via Automated Builds on Docker Hub. It takes just a few minutes of clicking to register and link the AB to GitHub's repo. Currently, I'm using one based off my fork successfully. I think it makes for an easy way to let people download the latest version easily.
I'm not too keen on this patch. What's even the point of running it in Docker? You still need fuse on the host and your run with privileged true and apparmor unconfined so you don't get any security benefits. Also, btfs is packages in Debian so you can just apt-get install it instead of building it yourself.
Thanks for reviewing @johang .
Security is not the main benefit I'm getting with this PR, indeed.
Mainly, I get a 'no-need-to-install-any-dependencies' development workflow (this is how I was able to hit the road quickly and pull #69 without risking my system installing dev deps).
Also, under Docker containers, you can create 'stacks', comprising several services and spin them up with a single docker-compose up command. For example, a UPnP/DLNA media sever mounting a btfs dir, all defined in a Docker Compose manifest.
Or just run one-off btfs instances and leave no traces after being done with them.
I've included an example Docker Compose manifest precisely to serve as example on how to correctly use FUSE from the Docker container. It might even help to pull the right docker run CLI switches for one-off runs just using it as reference, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
The former is used to build the code and create a Docker image. The latter contains the configuration (exposing FUSE from Docker is a bit tricky) to run a container from the previously built image which will mount Sintel on
/tmp/, as described in docs. Just dodocker-compose upas stated in docs.Using both files enabled me to develop and test #69 without needing to install any development libs or tools in my machine.
Optionally, the
Dockerfilecan also be used to create a public Docker image built from source to use as a distribution method via Automated Builds on Docker Hub. It takes just a few minutes of clicking to register and link the AB to GitHub's repo. Currently, I'm using one based off my fork successfully. I think it makes for an easy way to let people download the latest version easily.