-
-
Notifications
You must be signed in to change notification settings - Fork 13
Trending Feature: Store follower counts from the previous week and show the growth in percentage, also added Trending desc and asc filter to display trending users since last fetch #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @shihabhasan0161, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant 'Trending' feature, allowing users to discover GitHub profiles based on their recent follower growth. It involves both backend modifications to store and compute weekly follower percentage changes and frontend updates to display this growth prominently on user cards and provide new sorting functionalities. This enhancement aims to highlight active and growing profiles, improving user engagement and discoverability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a trending feature based on follower growth. The changes in fetch.py add logic to calculate this growth by comparing with data from the previous week, and the frontend is updated in script.js and layout.html to display and sort by this new metric. My review focuses on improving the robustness of the data loading in Python, fixing a sorting bug in JavaScript, and suggesting minor improvements for frontend code clarity and semantics. Overall, this is a great addition to the project.
a53590a to
3774f81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new trending feature based on follower growth, which is a great addition. The implementation in both the Python data fetching script and the JavaScript frontend is mostly well-executed. However, I've identified a critical bug in the JavaScript that breaks the 'I'm Feeling Lucky' button, and a high-severity logic issue in the Python script that could lead to data loss for the new trending feature under certain conditions. I've also included a minor suggestion to add missing CSS for the new growth indicator. Please review the comments for details and suggested fixes.
…ow the growth in percentage, also added Trending desc and asc filter to display trending users since last fetch
… add growth indicator styling
f34f91a to
08f5e7d
Compare
|
I am thinking, maybe this method not works as we are going to run the program every day once so Trending is not works here I guess. |
|
I will merge, but we might need to change some logic or time we are running the script once. like change daily to weekly or something. |
BaseMax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for now. looking forward for any ideas about improving.
Handled null cases. The growth of followers will be displayed in the user card like this: "Followers Growth (since last week): 0.01" only if the growth is > 0. Let me know if you want to display the negative growth as well.
Please verify if the code is working from your end as well.
Also, let me know if any changes needed. I'm happy to make any changes as needed.