Skip to content

Conversation

@shihabhasan0161
Copy link
Contributor

Handled null cases. The growth of followers will be displayed in the user card like this: "Followers Growth (since last week): 0.01" only if the growth is > 0. Let me know if you want to display the negative growth as well.

Please verify if the code is working from your end as well.

Also, let me know if any changes needed. I'm happy to make any changes as needed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shihabhasan0161, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant 'Trending' feature, allowing users to discover GitHub profiles based on their recent follower growth. It involves both backend modifications to store and compute weekly follower percentage changes and frontend updates to display this growth prominently on user cards and provide new sorting functionalities. This enhancement aims to highlight active and growing profiles, improving user engagement and discoverability.

Highlights

  • Trending Feature Implementation: Introduces a new 'Trending' feature that tracks and displays user follower growth over the past week.
  • Follower Growth Calculation: Implements backend logic to calculate the percentage growth of followers by comparing current counts with previously stored weekly snapshots.
  • UI Enhancements: Updates the frontend to display follower growth on user cards (if positive) and adds new sorting options for 'Trending (Followers ↑)' and 'Trending (Followers ↓)'.
  • Data Persistence for Growth: Modifies the data fetching script to load previous user data and store a 'followers_snapshot_at' timestamp, enabling historical comparison for growth metrics.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@deepsource-io
Copy link
Contributor

deepsource-io bot commented Dec 24, 2025

Here's the code health analysis summary for commits 4828164..08f5e7d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Python LogoPython❌ Failure
❗ 3 occurences introduced
🎯 1 occurence resolved
View Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a trending feature based on follower growth. The changes in fetch.py add logic to calculate this growth by comparing with data from the previous week, and the frontend is updated in script.js and layout.html to display and sort by this new metric. My review focuses on improving the robustness of the data loading in Python, fixing a sorting bug in JavaScript, and suggesting minor improvements for frontend code clarity and semantics. Overall, this is a great addition to the project.

@shihabhasan0161
Copy link
Contributor Author

@jbampton @BaseMax could you please check my pr for #165

Regarding the 593 lines of code, my code is just 82 lines. I did upstream to checkout this main repo to resolve the conflict. Only 82 lines new code was added by myself, others are already in this repo.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new trending feature based on follower growth, which is a great addition. The implementation in both the Python data fetching script and the JavaScript frontend is mostly well-executed. However, I've identified a critical bug in the JavaScript that breaks the 'I'm Feeling Lucky' button, and a high-severity logic issue in the Python script that could lead to data loss for the new trending feature under certain conditions. I've also included a minor suggestion to add missing CSS for the new growth indicator. Please review the comments for details and suggested fixes.

@BaseMax
Copy link
Member

BaseMax commented Dec 25, 2025

I am thinking, maybe this method not works as we are going to run the program every day once so Trending is not works here I guess.

@BaseMax
Copy link
Member

BaseMax commented Dec 25, 2025

I will merge, but we might need to change some logic or time we are running the script once. like change daily to weekly or something.

Copy link
Member

@BaseMax BaseMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for now. looking forward for any ideas about improving.

@BaseMax BaseMax merged commit c3ec67b into john-bampton:main Dec 25, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants