Increase JSCPD error threshold #216
Conversation
Summary of ChangesHello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adjusts the configuration for the JavaScript Code Plagiarism Detector (JSCPD) by raising its duplication threshold. This change aims to resolve an existing issue, likely by making the linter less strict and preventing it from flagging acceptable levels of code repetition. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying john-bampton with
|
| Latest commit: |
1824f8b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f8214477.john-bampton.pages.dev |
| Branch Preview URL: | https://jbampton-patch-1.john-bampton.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the allowed code duplication threshold for the jscpd linter from 2% to 2.5%. While this may be a necessary short-term fix to pass a failing CI check, it lowers the overall code quality gate for the project. Raising this threshold can lead to an accumulation of technical debt over time by permitting more duplicated code. My review includes a comment suggesting alternative approaches, such as using ignore patterns for specific, known duplications, which would be a more targeted solution than lowering the standard for the entire repository.
|
Here's the code health analysis summary for commits Analysis Summary
|
|
fixes #215