-
Notifications
You must be signed in to change notification settings - Fork 0
Switch from Gatsby to Astro #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure consistent frontmatter schema across all posts * Always write `description`, instead of relying on automatic excerpt calculation
While there, replace most incorrect prose uses of "&" with "and". Remark and Smartypants used to do smart quote replacement automatically at HTML generation time. With Astro and MDX, supposedly the parser only sees 1 quote character at a time, zero context, and Smartypants becomes useless. I did a bulk replace via a combination of `smartypants <file>` and `recode html..utf-8 <file>` and manual review.
18f289e to
9219cec
Compare
Newer versions of Prettier thinks it's wrapping long lines, but then MDX generates unwanted paragraphs.
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Closed
This comment was marked as outdated.
This comment was marked as outdated.
a50fbd2 to
18380d7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
* Follow Astro v5 upgrade guide * Work around removed type * Work around post non-deterministic sort * Remove slug and extension from content entries
I think Gatsby's SEO component used to provide it. With Astro, you write the regular, required HTML element directly.
* Regenerate lockfile
Astro's `entry.id` omitted a special character from 1 existing URL. Instead, parse the article filename on disk for the slug. This also restores 1 TitleCased URL, although that was redirected to be case insensitive automatically.
18380d7 to
b74934a
Compare
❗ page/posts-accumulating-multiple-failures-in-a-ValidationNEL__[w1280px] (click to expand)
❗ page/posts-accumulating-multiple-failures-in-a-ValidationNEL__[w414px] (click to expand)
❗ page/posts-dont-learn-to-code-learn-to-program-but-come-back-in-10-years__[w1280px] (click to expand)
❗ page/posts-dont-learn-to-code-learn-to-program-but-come-back-in-10-years__[w414px] (click to expand)
❗ page/posts-good-ideas-from-mobile-design-that-are-good-everywhere__[w1280px] (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.










































































Gatsby felt like overkill for this project: a small, static site, that doesn't even use a runtime framework like React.
Changes
description, instead of relying on automatic excerpt calculationsmartypants <file>andrecode html..utf-8 <file>and manual review.Discussion
The find-and-replace of smart quotes is the riskiest change in this PR, potentially losing words, like "&".
Review App
https://deploy-preview-29--john-kurkowski.netlify.app/
TODO
<ViewTransition />to every page. It helps a little.See the review app.<head>. 🤦 I think Gatsby's SEO component used to provide it. With Astro, you write the regular, required HTML element directly.