Skip to content

Add p2p plugin for static analysis#200

Open
szepeviktor wants to merge 1 commit intojohnbillion:developfrom
szepeviktor:patch-1
Open

Add p2p plugin for static analysis#200
szepeviktor wants to merge 1 commit intojohnbillion:developfrom
szepeviktor:patch-1

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Apr 30, 2022

Adding p2p:

composer require --dev scribu/lib-posts-to-posts:dev-master scribu/scb-framework:dev-master

Analysis result:

 ------ -----------------------------------------------------------
  Line   src/PostTypeAdmin.php
 ------ -----------------------------------------------------------
  1242   Cannot call method each_connected() on object|true.
  1474   Cannot call method direction_from_types() on object|true.
  1475   Cannot access property $side on object|true.
 ------ -----------------------------------------------------------

@johnbillion I leave this 💯% up to you.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Apr 30, 2022

The first step could be to add strict conditions.

// if ( $ctype )
if ( is_object( $ctype ) )
// or
if ( $ctype instanceof \P2P_Connection_Type )

But I do not know how this project operates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants