Add p2p plugin for static analysis#200
Open
szepeviktor wants to merge 1 commit intojohnbillion:developfrom
Open
Add p2p plugin for static analysis#200szepeviktor wants to merge 1 commit intojohnbillion:developfrom
szepeviktor wants to merge 1 commit intojohnbillion:developfrom
Conversation
Contributor
Author
|
The first step could be to add strict conditions. // if ( $ctype )
if ( is_object( $ctype ) )
// or
if ( $ctype instanceof \P2P_Connection_Type )But I do not know how this project operates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding p2p:
Analysis result:
@johnbillion I leave this 💯% up to you.