Do not call Globalize.parseFloat if the value is not a string.#7
Open
fredgate wants to merge 1 commit intojohnnyreilly:masterfrom
Open
Do not call Globalize.parseFloat if the value is not a string.#7fredgate wants to merge 1 commit intojohnnyreilly:masterfrom
fredgate wants to merge 1 commit intojohnnyreilly:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a input is of type number (instead of text) :
<input type="number" .... />
and that the user entered some letters, then jquery.validate uses false for the value of the input, and not the real string or a empty string.
This is done in the elementValue function :
In this case all the validation functions of jquery.validate.globalize working for numeric will fail as it call Globalize.parseFloat with a boolean parameter.
It is the case for the number, min, max, range functions.
In this function, instead of calling directly Globalize.parseFloat, I call a local function parseFloat that returns Globalize.parseFloat if the value is a string, otherwise an empty string.