Open
Conversation
|
Is this PR going to get merged? I'd love to use it! |
akhyarrh
added a commit
to akhyarrh/apropixyll
that referenced
this pull request
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass at this. It can be enabled by a config option. Once it stabilizes we can publicize and document it.
I considered having Jekyll produce two CSS files, one for default and one for dark mode: A conditional in the HTML templates would choose the right one. However, Sass is slow, so it was better to just produce only one CSS file. This required creating a copy of
_variables.scssand conditionally including these variables for dark mode. Should the_variables.scssbe renamed to_default.scssor some or other?Fixes #285.