Add strip=true to the repo examples
#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables strip in the example `Cargo.toml` files in this repository, per the recommendation now in README after johnthagen#34. The reminder to `strip` has been removed from the README, since the examples will now do that automatically.
|
Good catch. I'm slightly surprised the CI passed with this since we also target older Rust versions in CI. Does Cargo ignore unknown settings? |
|
Ah, I see it prints a warning: https://github.com/johnthagen/min-sized-rust/runs/5345941513?check_suite_focus=true#step:4:8 |
|
The warnings are unfortunate but I think this is still an overall net benefit so let's merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables strip in the example
Cargo.tomlfiles in this repository, per the recommendation now in README after #34.The reminder to
striphas been removed from the README, since the examples will now do that automatically.