-
Notifications
You must be signed in to change notification settings - Fork 171
makes namespaces psr4 compliant #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zghosts
wants to merge
63
commits into
joindin:master
Choose a base branch
from
zghosts:psr4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 40 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
7efc79d
move classes to namespace JoindIn\Web
zghosts 52b4b8c
move tests/phpunit.xml to phpunit.xml.dist
zghosts c3a2bda
fix references
zghosts 376d586
fix deprecations and remove unneeded/invalid parameters on the Constr…
zghosts d37cc8f
adds .idea to .gitignore
zghosts 459b1f3
fix deprecated DefaultCsrfProvider
zghosts 7f80f55
remove unused references
zghosts 7f65fdb
move classes to namespace JoindIn\Web
zghosts 245c331
move tests/phpunit.xml to phpunit.xml.dist
zghosts cda8b0f
fix references
zghosts af0a176
fix deprecations and remove unneeded/invalid parameters on the Constr…
zghosts 2950b92
adds .idea to .gitignore
zghosts 73c9767
fix deprecated DefaultCsrfProvider
zghosts 742aca3
remove unused references
zghosts 1f73eaa
fixes cs issue
zghosts 5f802fb
symplify fqcn
zghosts 6b0a057
add test for EventFormType
zghosts 12f92da
merge upstream
zghosts 2ee8fd0
remove unneeded csrf secret
zghosts ab0d8a8
add tests for middlewares
zghosts 5448715
add qa scripts to composer
zghosts e4926a5
cleanup test
zghosts 93fa1d2
use namespaced twig classes
zghosts 0e33c5b
merge upstream
zghosts 06e8cef
merge upstream
zghosts fa8c8c6
remove unused use statement for constraint
zghosts 0167318
fix array type in dockblocks
zghosts db63b27
add typehints to docblocks
zghosts da8784b
add typehint
zghosts 84a41ea
add typehints
zghosts 40cbf40
define continents and cities before modification
zghosts 52ec28e
update return types
zghosts 71715aa
typehint against FormInterface
zghosts 8653def
update param typehints
zghosts a6868cf
fix concatenation operator
zghosts 66ef241
add returntype
zghosts 5203902
remove nonexistent parameter from docblock
zghosts de6e112
merge upstream
zghosts 9fd7516
use array_merge to merge arrays
zghosts f9eefbc
revert to using phpunit 7 as symfony testcases are incompatible with …
zghosts a1e5438
merge upstream
zghosts e9863bf
run composer update
zghosts 03413a6
apply codestyle fixes
zghosts bae2f16
apply codestyle fixes
zghosts a96a26b
apply codestyle fixes
zghosts 7bf9b8f
merge upstream
zghosts 87f4130
remove unneeded preceding backslashed
zghosts 75091fc
fix config test
zghosts ff25b5a
optimize imports
zghosts 93dc846
apply codestyle fix
zghosts 28d2fef
cleanup imports
zghosts 9161a5a
Merge branch 'master' into psr4
iansltx 07f8124
Yes, PhpStorm, we need ext-json
iansltx 7fbb43e
Explicitly return null when a false-y event ID is passed
iansltx 1e40695
Fix typo in approveClaimPendingTalk
iansltx 9dfc660
Remove redundant/misleading echos on $this->render() calls
iansltx 0ab7002
make formtype compatible with symfony/form 3.4
zghosts 9ba8833
fix test
zghosts de27642
fix loading of translation with symfony 3.4
zghosts 1a6af6b
fix symfony deprecations
zghosts 94f096c
bump symfony components to 3.4
zghosts a0ba0cb
fix indentation
zghosts a4596ac
revert replacing twigrenderer with formrenderer
zghosts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| .idea | ||
| build/ | ||
| web/css/site.css | ||
| web/js/site.js | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <?php | ||
| namespace Application; | ||
| namespace JoindIn\Web\Application; | ||
|
|
||
| abstract class BaseApi | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <?php | ||
| namespace Application; | ||
| namespace JoindIn\Web\Application; | ||
|
|
||
| use Slim\Slim; | ||
| use Twig_Error_Runtime; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <?php | ||
| namespace Application; | ||
| namespace JoindIn\Web\Application; | ||
|
|
||
| use stdClass; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <?php | ||
| namespace Application; | ||
| namespace JoindIn\Web\Application; | ||
|
|
||
| /** | ||
| * Class CacheService | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <?php | ||
|
|
||
| namespace Application; | ||
| namespace JoindIn\Web\Application; | ||
|
|
||
| class Config implements \ArrayAccess | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.