Skip to content

Conversation

@ifeoluwaoladeji
Copy link
Contributor

Title: Add Efik (efik_NG) Locale to Faker

Description:

This pull request introduces support for the Efik language/locale (efik_NG) in the Faker library, enhancing Nigerian name coverage.

Changes made:

  • Added faker/providers/person/efik_NG provider with:

    • Male and female first names
    • Last names
    • Prefixes
  • Updated person/__init__.py to include efik_NG in the localized dictionary.

  • Added unit tests in tests/providers/test_person.py to verify the new locale.

  • Ensured all Faker tests pass with pytest.

References:

This extends Faker’s Nigerian locale support alongside previous contributions (e.g., ig_NG, yo_NG).

Test coverage:

  • Added tests for first name, last name, and prefixes generation for male, female, and generic cases.
  • All tests pass locally with Python 3.13 and pytest.

This PR ensures that Faker users can generate realistic Efik names for testing, seeding, or demo data purposes.

  • I have read the documentation about CONTRIBUTING
  • I have read the documentation about Coding style
  • I have run make lint

@ifeoluwaoladeji
Copy link
Contributor Author

This extends Faker’s Nigerian locale support alongside previous contributions (e.g., ig_NG, yo_NG).

@@ -0,0 +1,43 @@
# Data sources:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the ISO letter code for Efik is efi. Can you rename the module to efi_NG?

@ifeoluwaoladeji ifeoluwaoladeji changed the title Add nigerian locales Efik provider's name Add Nigerians efik_NG person provider Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants