Add major GR banks to el_GR bank provider #2306
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Added a banks tuple to the el_GR bank provider containing 13 GR banks, including systemic banks (e.g. Alpha Bank) and cooperative banks (e.g. Cooperative Bank of Chania). I only added banks that have a head office in Greece, and not branches of foreign-based banks. The information is sourced from the Bank of Greece (english, greek).
What was wrong
Previously, a call to the
bank()method when using theel_GRlocale would raise anattributeError, because the provider did not have abankstuple.How this fixes it
Added the missing
bankstuple to theel_GR/__init__.pyfile, enabling thebank()method to work correctly.Fixes #2305
A few comments
This is my first contribution to open source. I apologise if I missed a contributing standard. The linter technology is new to me, and to my understanding I cannot run
make linter, because I use a Windows machine. I used gen-AI (see section below) to run a list of "equal" commands based onMakefile. If I can do anything else please let me know.AI usage
I should clarify that I used gen-AI (specifically Google Gemini) to:
Checklist
make lint