Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uploading media that cannot be displayed on the web, we want to make sure that variations generated by jolimedia will be able to be displayed and embedded in web pages.
Therefore, the processors provided by JoliMedia only allow to output file types that can be displayed (eg. png, jpeg, webp, etc., but not tiff files).
However, it can be useful to allow for uploading tif or heic files, for example.
This PR allows to convert such files and generate the right variation file types according to the format constraints of each variation. In particular, with JoliMedia the default behavior when a Variation does not define any specific output format is to output a file of the same mime type like the original file. This PR addresses this point, and allows to generate variations in alternative formats (usually jpeg) for mime-types that cannot be displayed on the web.