Skip to content

when requesting a non existing variation URL, return a 404 NotFoundHttpException instead of a VariationNotFoundException#6

Merged
xavierlacot merged 2 commits intomainfrom
fix/notfoundhttpexception-on-unknown-variation
Jul 23, 2025
Merged

when requesting a non existing variation URL, return a 404 NotFoundHttpException instead of a VariationNotFoundException#6
xavierlacot merged 2 commits intomainfrom
fix/notfoundhttpexception-on-unknown-variation

Conversation

@xavierlacot
Copy link
Member

@xavierlacot xavierlacot commented Jul 23, 2025

No description provided.

@xavierlacot
when requesting a non existing variation URL, return a 404 NotFoundHt…
bb45cb1 
…tpException instead of a VariationNotFoundException
@xavierlacot xavierlacot added the enhancement New feature or request label Jul 23, 2025
@damienalexandre
Copy link
Member

damienalexandre commented Jul 23, 2025

Keep the domain exception and add it to the framework config:

# config/packages/framework.yaml
framework:
    exceptions:
        Symfony\Component\HttpKernel\Exception\BadRequestHttpException:
            log_level: debug
            status_code: 422
        App\Something\Exception\SomeException:
            log_level: alert
            status_code: 503

damienalexandre
damienalexandre requested changes Jul 23, 2025
View reviewed changes
Copy link
Member

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my previous comment ^^

@xavierlacot @damienalexandre
Update src/Controller/MediaController.php
4344fe0 
Co-authored-by: Damien Alexandre <mobman02@gmail.com>
@xavierlacot xavierlacot merged commit 9b1533a into main Jul 23, 2025
3 checks passed
@xavierlacot xavierlacot deleted the fix/notfoundhttpexception-on-unknown-variation branch July 23, 2025 08:49
@tacman tacman mentioned this pull request Nov 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damienalexandre damienalexandre damienalexandre requested changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xavierlacot @damienalexandre