fix(constructor): fixed circular references with promoted properties #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderVerkuil
force-pushed
the
fix/271/circular-references-with-promoted-properties
branch
from
4f156e3 to
30a6720
Compare
SanderVerkuil
changed the title
Korbeil
approved these changes
Jul 8, 2025
Member
Korbeil
left a comment
Korbeil
left a comment
There was a problem hiding this comment.
THanks for the fix @SanderVerkuil !
Could you add a note in the CHANGELOG about your changes please ? 🙏
SanderVerkuil
force-pushed
the
fix/271/circular-references-with-promoted-properties
branch
2 times, most recently
from
0ec8ce0 to
0c4618c
Compare
Author
|
@Korbeil Added the item to the changelog! |
Member
|
There is a failure in CS checks, could you run php-cs-fixer on your PR so it fixes it @SanderVerkuil ? 🙏 |
Circular references aren't handled with promoted properties Altered the statement to properly handle this case. Solves jolicode#271
SanderVerkuil
force-pushed
the
fix/271/circular-references-with-promoted-properties
branch
from
0c4618c to
553e208
Compare
Author
|
@Korbeil Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the generated mapper code such that circular references are handled properly when using promoted properties.
Solves #271