Skip to content

feat: allow specifying index name#215

Merged
damienalexandre merged 4 commits intojolicode:masterfrom
GaryPEGEOT:feat/specify-index
Nov 6, 2025
Merged

feat: allow specifying index name#215
damienalexandre merged 4 commits intojolicode:masterfrom
GaryPEGEOT:feat/specify-index

Conversation

@GaryPEGEOT
Copy link
Contributor

Fixes #213

@damienalexandre
Copy link
Member

Hello 👋 😄

Looks good, tests are red as you can see.

This is a useful feature, can you add a note in the changelog, as well as an example in the readme? (in the "demo" code block https://github.com/jolicode/elastically?tab=readme-ov-file#demo).

Thanks!

@GaryPEGEOT
Copy link
Contributor Author

Hello 👋 😄

Looks good, tests are red as you can see.

This is a useful feature, can you add a note in the changelog, as well as an example in the readme? (in the "demo" code block https://github.com/jolicode/elastically?tab=readme-ov-file#demo).

Thanks!

I forgot to rebase, should be good now! I've also updated the doc with examples

Copy link
Member

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an issue in the example :)

Co-authored-by: Damien Alexandre <mobman02@gmail.com>
@damienalexandre damienalexandre merged commit c5d6ab5 into jolicode:master Nov 6, 2025
9 checks passed
@damienalexandre
Copy link
Member

Thanks a lot 👏

@GaryPEGEOT GaryPEGEOT deleted the feat/specify-index branch November 6, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Allow specifying target index name(s) in IndexationRequest

2 participants