-
Notifications
You must be signed in to change notification settings - Fork 63
Update client cursor pagination #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hum the Check SDK is in sync with spec test is failing, but that's on us I think The Check Coding Standards test can be fixed on your side by running PHP CS Fixer ( |
|
I fixed Thanks! |
pyrech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 🎉
|
There is a problem with the tests - |
|
There is already a PR about the upload situation, if you want to jump in! :-) Thanks a lot for your contribution! |
|
When we merge on "main" tests are run on a real Slack API and it looks like one method fail: https://github.com/jolicode/slack-php-api/actions/runs/13564828905/job/37915496874 The only added method is https://api.slack.com/methods/usergroups.list so we probably need to add usergroups:read to our token. I will have a look later. |
|
Tests are green now I added the missing scope and updated the documentation. Thanks a lot. |

Discussed it on #177
Changes:
CURSOR_PAGINATIONconstant.Note: the virtual methods are not yet documented ...from the docs.