Add legacy (v4.4.x) toolchain support#249
Closed
tonyjackson-srt wants to merge 7 commits intojoltwallet:masterfrom
Closed
Add legacy (v4.4.x) toolchain support#249tonyjackson-srt wants to merge 7 commits intojoltwallet:masterfrom
tonyjackson-srt wants to merge 7 commits intojoltwallet:masterfrom
Conversation
…lback definition when the header isn’t available.
Member
|
Hey @tonyjackson-srt! Incase you are still working on this, I'm not particularly interested in re-adding esp-idf <v5 support. We removed it in #223 to simplify the code-base a bit. Given that esp-idf v4.4 EOL was July 2024 (16 months ago!). Thank you, though! |
Contributor
Author
|
Hi @BrianPugh, it was trivial modifying it to work with 4.4.8 (everything works except MMC support), but less so to get those changes to build against v5+. There might be a simple solution - however if there is no interest in supporting 4.4.x we can just keep those changes locally rather than pushing upstream. When I get there I can put up a PR just so you can see what was involved (which you'd be free to reject, of course!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for legacy projects pre-5.0. Tested against v4.4.8 locally.
It is only the SDMMC APIs that depend on 5.0+. There are recent changes to esp_littlefs that make using the latest version a desirable upgrade for older projects - in my case, the WDT servicing and access to fcntl(fd, F_GETPATH, …)