add flag to allow start ktea without logo#119
Open
offbythree wants to merge 8 commits intojonas-grgt:mainfrom
Open
add flag to allow start ktea without logo#119offbythree wants to merge 8 commits intojonas-grgt:mainfrom
offbythree wants to merge 8 commits intojonas-grgt:mainfrom
Conversation
…es/github.com/charmbracelet/bubbletea-1.3.10
Bumps [github.com/IBM/sarama](https://github.com/IBM/sarama) from 1.45.1 to 1.46.3. - [Release notes](https://github.com/IBM/sarama/releases) - [Changelog](https://github.com/IBM/sarama/blob/main/CHANGELOG.md) - [Commits](IBM/sarama@v1.45.1...v1.46.3) --- updated-dependencies: - dependency-name: github.com/IBM/sarama dependency-version: 1.46.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/linkedin/goavro/v2](https://github.com/linkedin/goavro) from 2.13.1 to 2.14.1. - [Release notes](https://github.com/linkedin/goavro/releases) - [Changelog](https://github.com/linkedin/goavro/blob/master/debug_release.go) - [Commits](linkedin/goavro@v2.13.1...v2.14.1) --- updated-dependencies: - dependency-name: github.com/linkedin/goavro/v2 dependency-version: 2.14.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/segmentio/kafka-go](https://github.com/segmentio/kafka-go) from 0.4.47 to 0.4.49. - [Release notes](https://github.com/segmentio/kafka-go/releases) - [Commits](segmentio/kafka-go@v0.4.47...v0.4.49) --- updated-dependencies: - dependency-name: github.com/segmentio/kafka-go dependency-version: 0.4.49 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/charmbracelet/log](https://github.com/charmbracelet/log) from 0.4.0 to 0.4.2. - [Release notes](https://github.com/charmbracelet/log/releases) - [Commits](charmbracelet/log@v0.4.0...v0.4.2) --- updated-dependencies: - dependency-name: github.com/charmbracelet/log dependency-version: 0.4.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
jonas-grgt
reviewed
Nov 22, 2025
cmd/ktea/main.go
Outdated
| var clustersTab = tab.Tab{Title: "Clusters", Label: clustersTabLbl} | ||
|
|
||
| type Model struct { | ||
| logoless bool |
jonas-grgt
reviewed
Nov 22, 2025
cmd/ktea/main.go
Outdated
| ) | ||
| flag.BoolVar(&debugParam, "debug", false, "enable debug") | ||
| flag.BoolVar(&plainFontsParam, "plain-fonts", false, "disable NerdFonts (if you see weird icons)") | ||
| flag.BoolVar(&logoless, "logoless", false, "start ktea without logo") |
Owner
There was a problem hiding this comment.
Maybe also call this hide-logo? so the param becomes -hide-logo
jonas-grgt
reviewed
Nov 22, 2025
cmd/ktea/main.go
Outdated
| kadmin.SaramaInstantiator(), | ||
| config.NewDefaultIO(), | ||
| ) | ||
| m.logoless = logoless |
Owner
There was a problem hiding this comment.
Maybe it is time to add some kind of configuration struct to bundle all configuration options like this one and disableNerdFonts
jonas-grgt
requested changes
Nov 22, 2025
Owner
jonas-grgt
left a comment
jonas-grgt
left a comment
There was a problem hiding this comment.
Great addition I'm just not sure about the param name.
Would it be possible to make this also stick as in; make it possible to configure this through the configuration file just like you can when plain fonts.
jonas-grgt
force-pushed
the
main
branch
3 times, most recently
from
5b1bf51 to
96acda6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.