Implement OneOrMany for std::collections::HashSet#925
Closed
tenuous-guidance wants to merge 1 commit intojonasbb:masterfrom
Closed
Implement OneOrMany for std::collections::HashSet#925tenuous-guidance wants to merge 1 commit intojonasbb:masterfrom
tenuous-guidance wants to merge 1 commit intojonasbb:masterfrom
Conversation
tenuous-guidance
force-pushed
the
one-or-many-hashset
branch
from
c1599dc to
e58a162
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
==========================================
+ Coverage 68.25% 68.39% +0.14%
==========================================
Files 36 36
Lines 9592 9636 +44
==========================================
+ Hits 6547 6591 +44
Misses 3045 3045 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tenuous-guidance
force-pushed
the
one-or-many-hashset
branch
2 times, most recently
from
12819cb to
523d474
Compare
tenuous-guidance
force-pushed
the
one-or-many-hashset
branch
from
523d474 to
3c52eb9
Compare
Closed
Owner
|
Thanks you for the PR. I see how extending the implementation can be useful, but I have a different implementation plan in #929. I did however copy over your tests. |
jonasbb
added a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.